<html>
<head><meta charset="utf-8"><title>adding labels to stable-to-stable regressions · t-compiler/wg-prioritization · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/index.html">t-compiler/wg-prioritization</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/adding.20labels.20to.20stable-to-stable.20regressions.html">adding labels to stable-to-stable regressions</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="220514432"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/adding%20labels%20to%20stable-to-stable%20regressions/near/220514432" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/adding.20labels.20to.20stable-to-stable.20regressions.html#220514432">(Dec 20 2020 at 10:48)</a>:</h4>
<p>I compiled a list of more than 80 glacier files that trigger an ICE on stable rustc in some way.<br>
Should I apply the <code>regression-from-stable-to-stable</code> label to all of them (if they don't have it already?)<br>
This would probably cause a flood of notifications in the <code>-alerts</code> channel</p>



<a name="220521391"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/adding%20labels%20to%20stable-to-stable%20regressions/near/220521391" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/adding.20labels.20to.20stable-to-stable.20regressions.html#220521391">(Dec 20 2020 at 13:59)</a>:</h4>
<p><span class="user-mention" data-user-id="217864">@matthiaskrgr</span> you should ask in <a class="stream" data-stream-id="227806" href="/#narrow/stream/227806-t-compiler.2Fwg-prioritization">#t-compiler/wg-prioritization</a> I think</p>



<a name="220527178"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/adding%20labels%20to%20stable-to-stable%20regressions/near/220527178" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/adding.20labels.20to.20stable-to-stable.20regressions.html#220527178">(Dec 20 2020 at 16:45)</a>:</h4>
<p>oh oops I thought this was t-compiler/help lmao</p>



<a name="220527179"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/adding%20labels%20to%20stable-to-stable%20regressions/near/220527179" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/adding.20labels.20to.20stable-to-stable.20regressions.html#220527179">(Dec 20 2020 at 16:45)</a>:</h4>
<p>sorry for the false alarm</p>



<a name="220528007"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/adding%20labels%20to%20stable-to-stable%20regressions/near/220528007" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/adding.20labels.20to.20stable-to-stable.20regressions.html#220528007">(Dec 20 2020 at 17:07)</a>:</h4>
<p>hm but are they regressions?</p>



<a name="220528767"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/adding%20labels%20to%20stable-to-stable%20regressions/near/220528767" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/adding.20labels.20to.20stable-to-stable.20regressions.html#220528767">(Dec 20 2020 at 17:30)</a>:</h4>
<p>do we have a definition for "regression"?<br>
is "compiler rejected this code" =&gt; "internal compiler panic on this code" a regression?</p>



<a name="220528816"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/adding%20labels%20to%20stable-to-stable%20regressions/near/220528816" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/adding.20labels.20to.20stable-to-stable.20regressions.html#220528816">(Dec 20 2020 at 17:31)</a>:</h4>
<p>I think so, but I thought glacier was added to on ICEs only? I would want a version where it <em>didn't</em> ICE I think before tagging as a regression</p>



<a name="220529111"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/adding%20labels%20to%20stable-to-stable%20regressions/near/220529111" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/adding.20labels.20to.20stable-to-stable.20regressions.html#220529111">(Dec 20 2020 at 17:38)</a>:</h4>
<p>I see <span aria-label="+1" class="emoji emoji-1f44d" role="img" title="+1">:+1:</span></p>



<a name="220537715"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/adding%20labels%20to%20stable-to-stable%20regressions/near/220537715" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/adding.20labels.20to.20stable-to-stable.20regressions.html#220537715">(Dec 20 2020 at 21:13)</a>:</h4>
<p>And also: please try to not do too many at a time or you'll overwhelm us <span aria-label="sweat smile" class="emoji emoji-1f605" role="img" title="sweat smile">:sweat_smile:</span></p>



<a name="221211517"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/adding%20labels%20to%20stable-to-stable%20regressions/near/221211517" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> apiraino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/adding.20labels.20to.20stable-to-stable.20regressions.html#221211517">(Dec 30 2020 at 13:16)</a>:</h4>
<p>I was wondering if this list of regression should be assigned a priority label - <span class="user-mention" data-user-id="116266">@Santiago Pastorino</span> (and others) what's your opinion? Just to see if there is anything critical in any of those regresssions.</p>



<a name="221211543"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/adding%20labels%20to%20stable-to-stable%20regressions/near/221211543" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> apiraino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/adding.20labels.20to.20stable-to-stable.20regressions.html#221211543">(Dec 30 2020 at 13:16)</a>:</h4>
<p>Are these issues already all filed in the issue tracker <span class="user-mention" data-user-id="217864">@matthiaskrgr</span> ?</p>



<a name="221211696"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/adding%20labels%20to%20stable-to-stable%20regressions/near/221211696" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> apiraino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/adding.20labels.20to.20stable-to-stable.20regressions.html#221211696">(Dec 30 2020 at 13:19)</a>:</h4>
<p>if not (or if not all of them are already filed) I was thinking if it could make sense a quick review of them, assign a priority, then file them in the issue tracker with already a priority</p>



<a name="221211791"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/adding%20labels%20to%20stable-to-stable%20regressions/near/221211791" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> apiraino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/adding.20labels.20to.20stable-to-stable.20regressions.html#221211791">(Dec 30 2020 at 13:20)</a>:</h4>
<p>reason is that many of ICE issues might end up with a <code>P-medium</code> priority label, meaning they're under the radar but do not require immediate attention</p>



<a name="221212695"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/adding%20labels%20to%20stable-to-stable%20regressions/near/221212695" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/adding.20labels.20to.20stable-to-stable.20regressions.html#221212695">(Dec 30 2020 at 13:36)</a>:</h4>
<p>looks like all of the current rustc-repo stable ICES are known, a couple of them have notes inside the test that this causes an ICE under some circumstances</p>



<a name="221215923"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/adding%20labels%20to%20stable-to-stable%20regressions/near/221215923" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> apiraino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/adding.20labels.20to.20stable-to-stable.20regressions.html#221215923">(Dec 30 2020 at 14:25)</a>:</h4>
<p>ok, so they are under control, thanks <span aria-label="thumbs up" class="emoji emoji-1f44d" role="img" title="thumbs up">:thumbs_up:</span></p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>